[Microsoft SQLServer] Add support for list of Dynamic Counter values #14153
+50
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muthu-mps
added
Integration:microsoft_sqlserver
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @muthu-mps |
|
ishleenk17
reviewed
Jun 9, 2025
| @@ -43,8 +43,12 @@ sql_queries: | |||
| response_format: table | |||
| - query: "SELECT cntr_value As 're_compilations_per_sec' FROM sys.dm_os_performance_counters WHERE counter_name = 'SQL Re-Compilations/sec'" | |||
| response_format: table | |||
| - query: "SELECT counter_name, cntr_value FROM sys.dm_os_performance_counters WHERE counter_name like '{{dynamic_counter_name}}'" | |||
| {{#if dynamic_counter_name}} | |||
| {{#each dynamic_counter_name as | dynamic_counter i|}} | |||
There was a problem hiding this comment.
Do we intend to use "i" anywhere, else remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see this issue for more details.
This PR adds capability to pass list of dynamic counter values. This way user has more flexibility to add multiple values as input to fetch the desired metrics.
This change introduces a breaking update, which is why we are releasing a new major version. Users will need to manually remove the dynamic counter input from the UI, upgrade the integration, and then re-add the dynamic counters. This is necessary because the input parameter type has changed from text to array.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues